| Anonymous | Login | Signup for a new account | 2010-09-10 19:50 UTC | |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ << ] [ >> ] | [ Issue History ] [ Print ] | |||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||
| 0000509 | pzs-ng v1.1 | general | public | 2010-02-01 10:24 | 2010-02-02 19:37 | ||||||
| Reporter | Skeddie | ||||||||||
| Assigned To | |||||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||||
| Status | new | Resolution | open | ||||||||
| Platform | OS | OS Version | |||||||||
| Product Version | |||||||||||
| Target Version | Fixed in Version | ||||||||||
| Summary | 0000509: psxc-imdb: Empty Director-string when multiple directors | ||||||||||
| Description | Films with multiple directors aren't parsed correctly, resulting in an empty IMDBDIRECTOR-string. | ||||||||||
| Steps To Reproduce | -Make a new dir -Upload nfo with imdblink for a film with multiple directors (ie Bolt) -Check created .imdb file: no 'Directed by'-line | ||||||||||
| Additional Information | Fix lists all directors on one line seperated by a colon |: --- psxc-imdb.v2.9h.sh 2010-02-01 11:14:05.000000000 +0100 +++ psxc-imdb.sh 2010-02-01 11:14:34.000000000 +0100 @@ -566,7 +566,7 @@ if [ ! -z "$RUNTIMECLEAN" ]; then RUNTIMECLEAN="$RUNTIMECLEAN min" fi - DIRECTOR=$(cat $TMPFILE | grep -a "Director:" | head -n 1 | cut -d ':' -f 2- | sed "s/ *//") + DIRECTOR=$(awk '/Director[s]*:/, /Writer[s]*( \(WGA\))*:/' $TMPFILE | grep -v "Writer" | sed 's/^Director[s]*: //' | tr ' ' '_' | xargs | sed -e 's/ _/ \| /g' -e 's/\"/$QUOTECHAR/g' | tr '_' ' ') # DIRECTOR=$(cat $TMPFILE | awk '/Director:$/, /Writers:$/' | grep -a -v "Director:" | grep -a -v "Writers:" | grep -a -v "^$" | sed "s/^\ *//g" | sed "s/\ *$//g" | head -n 1 | sed s/\"/$QUOTECHAR/g) DIRECTORCLEAN=$(echo $DIRECTOR) if [ ! -z "$(echo "$DIRECTOR" | grep -a -e "\(\ \)\ \(\ \)")" ]; then | ||||||||||
| Tags | No tags attached. | ||||||||||
| Attached Files | |||||||||||
 Relationships |
|
 Relationships |
|
Notes |
|
|
(0000973) Skeddie (reporter) 2010-02-02 19:37 |
Having thouroughly tested this, I found it to be only 99% correct. The above line will fail on films like Twist Of Faith; following line should be 99.99% to 100%: DIRECTOR=$(sed -n '/^Director[s]*:/,/:/p' $TMPFILE | sed '$d' | sed -e 's/^Director[s]*: //' -e 's/(.*)//' | tr ' ' '_' | xargs | sed -e 's/ _/ \| /g' -e 's/\"/$QUOTECHAR/g' | tr '_' ' ') |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-02-01 10:24 | Skeddie | New Issue | |
| 2010-02-02 19:37 | Skeddie | Note Added: 0000973 | |
|
Issue History |
| Main | My View | View Issues | Change Log | Roadmap |
| Copyright © 2000 - 2010 MantisBT Group |
 |